u70b3 commented on PR #23722: URL: https://github.com/apache/datafusion/pull/23722#issuecomment-5030932619
Confirmed — thanks for the quick turnaround! I pulled the new head (`3fd1b57a`) and verified locally: - Rebase looks right: the branch now sits on a post-#23704 main, so the mixed-width case (`Dictionary(_, Utf8View)` / `LargeUtf8` value side) is a clean error instead of a panic. - `rustfmt --check` passes — restoring the doc comments fixed the fmt job. - `test_regex_match_dyn_dictionary` passes, and the arm is now covered independently of the planner's cast path. - slt wording + trailing newline fixed. One tiny leftover: the PR body still has stray `<!--` / `-->` markers, so the "Are these changes tested?" section renders inside a comment — worth fixing while waiting on CI. CI on the new commit hasn't started yet (a maintainer needs to approve the run for first-time contributors). Once it's green, this looks ready to me — nice work! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
