github-actions[bot] commented on PR #23738: URL: https://github.com/apache/datafusion/pull/23738#issuecomment-5031497332
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion v54.0.0 (current) Built [ 111.767s] (current) Parsing datafusion v54.0.0 (current) Parsed [ 0.037s] (current) Building datafusion v54.0.0 (baseline) Built [ 108.001s] (baseline) Parsing datafusion v54.0.0 (baseline) Parsed [ 0.037s] (baseline) Checking datafusion v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.965s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 222.712s] datafusion Building datafusion-expr v54.0.0 (current) Built [ 26.426s] (current) Parsing datafusion-expr v54.0.0 (current) Parsed [ 0.080s] (current) Building datafusion-expr v54.0.0 (baseline) Built [ 26.535s] (baseline) Parsing datafusion-expr v54.0.0 (baseline) Parsed [ 0.081s] (baseline) Checking datafusion-expr v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 2.020s] 223 checks: 221 pass, 1 fail, 1 warn, 30 skip --- failure enum_variant_added: enum variant added on exhaustive enum --- Description: A publicly-visible enum without #[non_exhaustive] has a new variant. ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/enum_variant_added.ron Failed in: variant LogicalPlan:AsOfJoin in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:245 variant LogicalPlan:AsOfJoin in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:245 --- warning partial_ord_enum_variants_reordered: enum variants reordered in #[derive(PartialOrd)] enum --- Description: A public enum that derives PartialOrd had its variants reordered. #[derive(PartialOrd)] uses the enum variant order to set the enum's ordering behavior, so this change may break downstream code that relies on the previous order. ref: https://doc.rust-lang.org/std/cmp/trait.PartialOrd.html#derivable impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/partial_ord_enum_variants_reordered.ron Failed in: LogicalPlan::Repartition moved from position 7 to 8, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:249 LogicalPlan::Union moved from position 8 to 9, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:253 LogicalPlan::TableScan moved from position 9 to 10, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:256 LogicalPlan::EmptyRelation moved from position 10 to 11, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:260 LogicalPlan::Subquery moved from position 11 to 12, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:263 LogicalPlan::SubqueryAlias moved from position 12 to 13, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:265 LogicalPlan::Limit moved from position 13 to 14, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:267 LogicalPlan::Statement moved from position 14 to 15, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:269 LogicalPlan::Values moved from position 15 to 16, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:274 LogicalPlan::Explain moved from position 16 to 17, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:277 LogicalPlan::Analyze moved from position 17 to 18, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:281 LogicalPlan::Extension moved from position 18 to 19, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:284 LogicalPlan::Distinct moved from position 19 to 20, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:287 LogicalPlan::Dml moved from position 20 to 21, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:289 LogicalPlan::Ddl moved from position 21 to 22, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:291 LogicalPlan::Copy moved from position 22 to 23, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:293 LogicalPlan::DescribeTable moved from position 23 to 24, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:296 LogicalPlan::Unnest moved from position 24 to 25, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:299 LogicalPlan::RecursiveQuery moved from position 25 to 26, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:301 LogicalPlan::Repartition moved from position 7 to 8, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:249 LogicalPlan::Union moved from position 8 to 9, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:253 LogicalPlan::TableScan moved from position 9 to 10, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:256 LogicalPlan::EmptyRelation moved from position 10 to 11, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:260 LogicalPlan::Subquery moved from position 11 to 12, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:263 LogicalPlan::SubqueryAlias moved from position 12 to 13, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:265 LogicalPlan::Limit moved from position 13 to 14, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:267 LogicalPlan::Statement moved from position 14 to 15, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:269 LogicalPlan::Values moved from position 15 to 16, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:274 LogicalPlan::Explain moved from position 16 to 17, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:277 LogicalPlan::Analyze moved from position 17 to 18, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:281 LogicalPlan::Extension moved from position 18 to 19, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:284 LogicalPlan::Distinct moved from position 19 to 20, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:287 LogicalPlan::Dml moved from position 20 to 21, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:289 LogicalPlan::Ddl moved from position 21 to 22, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:291 LogicalPlan::Copy moved from position 22 to 23, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:293 LogicalPlan::DescribeTable moved from position 23 to 24, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:296 LogicalPlan::Unnest moved from position 24 to 25, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:299 LogicalPlan::RecursiveQuery moved from position 25 to 26, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:301 Summary semver requires new major version: 1 major and 0 minor checks failed Warning produced 1 major and 0 minor level warnings Finished [ 56.137s] datafusion-expr Building datafusion-optimizer v54.0.0 (current) Built [ 26.657s] (current) Parsing datafusion-optimizer v54.0.0 (current) Parsed [ 0.034s] (current) Building datafusion-optimizer v54.0.0 (baseline) Built [ 26.913s] (baseline) Parsing datafusion-optimizer v54.0.0 (baseline) Parsed [ 0.034s] (baseline) Checking datafusion-optimizer v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.239s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 54.896s] datafusion-optimizer Building datafusion-physical-plan v54.0.0 (current) Built [ 36.558s] (current) Parsing datafusion-physical-plan v54.0.0 (current) Parsed [ 0.152s] (current) Building datafusion-physical-plan v54.0.0 (baseline) Built [ 36.343s] (baseline) Parsing datafusion-physical-plan v54.0.0 (baseline) Parsed [ 0.152s] (baseline) Checking datafusion-physical-plan v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 1.019s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 75.837s] datafusion-physical-plan Building datafusion-proto v54.0.0 (current) Built [ 60.483s] (current) Parsing datafusion-proto v54.0.0 (current) Parsed [ 0.020s] (current) Building datafusion-proto v54.0.0 (baseline) Built [ 59.515s] (baseline) Parsing datafusion-proto v54.0.0 (baseline) Parsed [ 0.021s] (baseline) Checking datafusion-proto v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.363s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 121.572s] datafusion-proto Building datafusion-proto-models v54.0.0 (current) Built [ 24.148s] (current) Parsing datafusion-proto-models v54.0.0 (current) Parsed [ 0.138s] (current) Building datafusion-proto-models v54.0.0 (baseline) Built [ 24.055s] (baseline) Parsing datafusion-proto-models v54.0.0 (baseline) Parsed [ 0.139s] (baseline) Checking datafusion-proto-models v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 2.641s] 223 checks: 222 pass, 1 fail, 0 warn, 30 skip --- failure enum_variant_added: enum variant added on exhaustive enum --- Description: A publicly-visible enum without #[non_exhaustive] has a new variant. ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/enum_variant_added.ron Failed in: variant LogicalPlanType:AsOfJoin in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:83 variant LogicalPlanType:AsOfJoin in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:83 variant PhysicalPlanType:AsOfJoin in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:1407 variant PhysicalPlanType:AsOfJoin in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:1407 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 52.427s] datafusion-proto-models Building datafusion-sql v54.0.0 (current) Built [ 40.442s] (current) Parsing datafusion-sql v54.0.0 (current) Parsed [ 0.033s] (current) Building datafusion-sql v54.0.0 (baseline) Built [ 40.576s] (baseline) Parsing datafusion-sql v54.0.0 (baseline) Parsed [ 0.035s] (baseline) Checking datafusion-sql v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.363s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 82.570s] datafusion-sql Building datafusion-substrait v54.0.0 (current) Built [ 333.958s] (current) Parsing datafusion-substrait v54.0.0 (current) Parsed [ 0.019s] (current) Building datafusion-substrait v54.0.0 (baseline) Built [ 335.995s] (baseline) Parsing datafusion-substrait v54.0.0 (baseline) Parsed [ 0.019s] (baseline) Checking datafusion-substrait v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.319s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 672.161s] datafusion-substrait ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
