xudong963 commented on PR #23738: URL: https://github.com/apache/datafusion/pull/23738#issuecomment-5052944642
> Thank you @Xuanwo -- I think it is not likely I will be able to find time to carefully review a 4500 line PR > > It is really helpful to see the design running end to end > > Is there any chance you can break this one up into smaller PRs for easier review: > > 1. benchmarks > 2. SQL support / LogicalPlan > 3. Physical operator (maybe we can break it down more) > 4. The Dataframe API Yeah, agree. If we agree with the PR direction, then it's better to split into a couple of small PRs to make it easier to move forward. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
