mbutrovich commented on code in PR #4991:
URL: https://github.com/apache/datafusion-comet/pull/4991#discussion_r3625405109
##########
spark/pom.xml:
##########
@@ -107,6 +107,13 @@ under the License.
<artifactId>spark-hadoop-cloud_${scala.binary.version}</artifactId>
<classifier>tests</classifier>
</dependency>
+ <dependency>
+ <!-- Test-only: provides an embedded Hive metastore so Iceberg's
type=hive catalog can
+ create encrypted tables (only Hive wires the KMS-backed
EncryptionManager). Version and
+ scope come from the parent pom's dependencyManagement. -->
+ <groupId>org.apache.spark</groupId>
+ <artifactId>spark-hive_${scala.binary.version}</artifactId>
Review Comment:
The scope is inherited from the parent pom's dependencyManagement, which
declares spark-hive as test scope. That is why it is omitted here, matching the
spark-sql and spark-hadoop-cloud test deps just above. The inline comment notes
this. Happy to make it explicit if you would prefer it spelled out on the
dependency itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
