mbutrovich commented on code in PR #4991:
URL: https://github.com/apache/datafusion-comet/pull/4991#discussion_r3631213270
##########
.github/actions/java-test/action.yaml:
##########
@@ -50,6 +50,18 @@ runs:
cd native
cargo build --release
+ # Evaluate hashFiles now, on the clean checkout, and reuse the result in
the
+ # cache key below. The cache step's inputs are re-evaluated when its post
+ # (cache-save) phase runs, and by then the test run has left trees under
the
+ # workspace (e.g. the Hive-catalog warehouse from
CometIcebergEncryptionSuite)
+ # that make a fresh '**/pom.xml' walk throw "Fail to hash files under
+ # directory". A precomputed string keeps the save phase from re-walking
them.
Review Comment:
I also added some cleanup logic for the Hive-catalog, but just in case I'm
also addressing the footgun here. It fixed a failure in the `Post Java test
steps`:
```
Post job cleanup.
Error: The template is not valid.
/home/runner/work/datafusion-comet/datafusion-comet/./.github/actions/java-test/action.yaml
(Line: 63, Col: 14): hashFiles('**/pom.xml') failed. Fail to hash files under
directory '/home/runner/work/datafusion-comet/datafusion-comet'
```
that I saw after adding the Hive catalog
https://github.com/apache/datafusion-comet/actions/runs/29912607672/job/88905543943
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
