github-actions[bot] commented on PR #23627: URL: https://github.com/apache/datafusion/pull/23627#issuecomment-5042721249
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion v54.0.0 (current) Built [ 105.192s] (current) Parsing datafusion v54.0.0 (current) Parsed [ 0.035s] (current) Building datafusion v54.1.0 (baseline) Built [ 106.293s] (baseline) Parsing datafusion v54.1.0 (baseline) Parsed [ 0.036s] (baseline) Checking datafusion v54.1.0 -> v54.0.0 (minor change) Checked [ 0.597s] 196 checks: 194 pass, 2 fail, 0 warn, 57 skip --- failure function_parameter_count_changed: pub fn parameter count changed --- Description: A publicly-visible function now takes a different number of parameters. ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/function_parameter_count_changed.ron Failed in: datafusion::physical_planner::create_window_expr_with_name now takes 4 parameters instead of 5, in /home/runner/work/datafusion/datafusion/datafusion/core/src/physical_planner.rs:2420 datafusion::physical_planner::create_window_expr now takes 3 parameters instead of 4, in /home/runner/work/datafusion/datafusion/datafusion/core/src/physical_planner.rs:2484 --- failure trait_method_parameter_count_changed: pub trait method parameter count changed --- Description: A trait method now takes a different number of parameters. ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-item-signature impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/trait_method_parameter_count_changed.ron Failed in: ExtensionPlanner::plan_extension now takes 5 instead of 6 parameters, in file /home/runner/work/datafusion/datafusion/datafusion/core/src/physical_planner.rs:159 ExtensionPlanner::plan_table_scan now takes 3 instead of 4 parameters, in file /home/runner/work/datafusion/datafusion/datafusion/core/src/physical_planner.rs:233 PhysicalPlanner::create_physical_expr now takes 3 instead of 4 parameters, in file /home/runner/work/datafusion/datafusion/datafusion/core/src/physical_planner.rs:138 Summary semver requires new major version: 2 major and 0 minor checks failed Finished [ 214.371s] datafusion Building datafusion-physical-plan v54.0.0 (current) Built [ 38.103s] (current) Parsing datafusion-physical-plan v54.0.0 (current) Parsed [ 0.141s] (current) Building datafusion-physical-plan v54.1.0 (baseline) Built [ 37.626s] (baseline) Parsing datafusion-physical-plan v54.1.0 (baseline) Parsed [ 0.144s] (baseline) Checking datafusion-physical-plan v54.1.0 -> v54.0.0 (minor change) Checked [ 0.631s] 196 checks: 195 pass, 1 fail, 0 warn, 57 skip --- failure inherent_method_missing: pub method removed or renamed --- Description: A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/inherent_method_missing.ron Failed in: CooperativeExec::try_from_proto, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/ee96a050e136ab3f6e112f48294ae88c11a7d03a/datafusion/physical-plan/src/coop.rs:399 CoalescePartitionsExec::try_from_proto, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/ee96a050e136ab3f6e112f48294ae88c11a7d03a/datafusion/physical-plan/src/coalesce_partitions.rs:379 CoalesceBatchesExec::try_from_proto, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/ee96a050e136ab3f6e112f48294ae88c11a7d03a/datafusion/physical-plan/src/coalesce_batches.rs:328 FilterExec::try_from_proto, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/ee96a050e136ab3f6e112f48294ae88c11a7d03a/datafusion/physical-plan/src/filter.rs:860 SortMergeJoinExec::try_from_proto, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/ee96a050e136ab3f6e112f48294ae88c11a7d03a/datafusion/physical-plan/src/joins/sort_merge_join/exec.rs:754 BufferExec::try_from_proto, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/ee96a050e136ab3f6e112f48294ae88c11a7d03a/datafusion/physical-plan/src/buffer.rs:329 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 77.898s] datafusion-physical-plan ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
