2010YOUY01 commented on code in PR #23738:
URL: https://github.com/apache/datafusion/pull/23738#discussion_r3635148503
##########
datafusion/sql/src/unparser/plan.rs:
##########
@@ -115,6 +115,7 @@ impl Unparser<'_> {
| LogicalPlan::Aggregate(_)
| LogicalPlan::Sort(_)
| LogicalPlan::Join(_)
+ | LogicalPlan::AsOfJoin(_)
Review Comment:
I think ASOF joins and regular joins are different relational operations. If
many planning or logical optimization tasks apply only to ASOF joins, splitting
them would probably simplify the implementation; otherwise, they should remain
combined.
(I’m not sure about the current state of the implementation, and which
approach should we take.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
