neilconway commented on PR #23850: URL: https://github.com/apache/datafusion/pull/23850#issuecomment-5070429992
I wonder if it would be net simpler to split the registry data into two fields. For example: 1. `scalar_functions_snapshot`, which is an optional hashmap that comes via `new_with_existing` 2. `scalar_functions_extra`, which is the user-supplied `Vec` with additional registrations Then `build()` would install the snapshot as-is and then apply the vec of additional registrations on top. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
