timsaucer commented on code in PR #23069:
URL: https://github.com/apache/datafusion/pull/23069#discussion_r3652733519
##########
datafusion/ffi/src/tests/udf_udaf_udwf.rs:
##########
@@ -162,6 +163,50 @@ pub(crate) extern "C" fn create_placement_func() ->
FFI_ScalarUDF {
udf.into()
}
+#[derive(Debug, PartialEq, Eq, Hash)]
+struct LexOrderingUDF {
+ signature: Signature,
+}
Review Comment:
Similar to your other PR it seems like we're just adding bloat to this file.
Can we just implement this function on one of the existing scalar UDFs?
##########
datafusion/ffi/src/udf/mod.rs:
##########
@@ -502,6 +536,33 @@ mod tests {
}
}
+ #[derive(Debug, PartialEq, Eq, Hash)]
+ struct LexOrderingUDF {
+ signature: Signature,
+ }
Review Comment:
Like with the other comment, if we can avoid impl bloat just to cover this
function that would be my preference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
