Amogh-2404 commented on code in PR #23069:
URL: https://github.com/apache/datafusion/pull/23069#discussion_r3652745750
##########
datafusion/ffi/src/tests/udf_udaf_udwf.rs:
##########
@@ -162,6 +163,50 @@ pub(crate) extern "C" fn create_placement_func() ->
FFI_ScalarUDF {
udf.into()
}
+#[derive(Debug, PartialEq, Eq, Hash)]
+struct LexOrderingUDF {
+ signature: Signature,
+}
Review Comment:
Agreed. I will fold the unit and cross-library checks into the existing
scalar UDF fixtures and remove the dedicated implementations before updating
the branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
