github-actions[bot] commented on PR #23676: URL: https://github.com/apache/datafusion/pull/23676#issuecomment-5084712192
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion v54.0.0 (current) Built [ 112.967s] (current) Parsing datafusion v54.0.0 (current) Parsed [ 0.037s] (current) Building datafusion v54.1.0 (baseline) Built [ 110.396s] (baseline) Parsing datafusion v54.1.0 (baseline) Parsed [ 0.035s] (baseline) Checking datafusion v54.1.0 -> v54.0.0 (minor change) Checked [ 0.547s] 196 checks: 194 pass, 2 fail, 0 warn, 57 skip --- failure function_parameter_count_changed: pub fn parameter count changed --- Description: A publicly-visible function now takes a different number of parameters. ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/function_parameter_count_changed.ron Failed in: datafusion::physical_planner::create_window_expr_with_name now takes 4 parameters instead of 5, in /home/runner/work/datafusion/datafusion/datafusion/core/src/physical_planner.rs:2420 datafusion::physical_planner::create_window_expr now takes 3 parameters instead of 4, in /home/runner/work/datafusion/datafusion/datafusion/core/src/physical_planner.rs:2484 --- failure trait_method_parameter_count_changed: pub trait method parameter count changed --- Description: A trait method now takes a different number of parameters. ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-item-signature impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/trait_method_parameter_count_changed.ron Failed in: PhysicalPlanner::create_physical_expr now takes 3 instead of 4 parameters, in file /home/runner/work/datafusion/datafusion/datafusion/core/src/physical_planner.rs:138 ExtensionPlanner::plan_extension now takes 5 instead of 6 parameters, in file /home/runner/work/datafusion/datafusion/datafusion/core/src/physical_planner.rs:159 ExtensionPlanner::plan_table_scan now takes 3 instead of 4 parameters, in file /home/runner/work/datafusion/datafusion/datafusion/core/src/physical_planner.rs:233 Summary semver requires new major version: 2 major and 0 minor checks failed Finished [ 225.997s] datafusion Building datafusion-functions v54.0.0 (current) Built [ 32.285s] (current) Parsing datafusion-functions v54.0.0 (current) Parsed [ 0.087s] (current) Building datafusion-functions v54.1.0 (baseline) Built [ 30.876s] (baseline) Parsing datafusion-functions v54.1.0 (baseline) Parsed [ 0.086s] (baseline) Checking datafusion-functions v54.1.0 -> v54.0.0 (minor change) Checked [ 0.373s] 196 checks: 196 pass, 57 skip Summary no semver update required Finished [ 64.879s] datafusion-functions Building datafusion-sqllogictest v54.0.0 (current) Built [ 185.481s] (current) Parsing datafusion-sqllogictest v54.0.0 (current) Parsed [ 0.022s] (current) Building datafusion-sqllogictest v54.1.0 (baseline) Built [ 186.944s] (baseline) Parsing datafusion-sqllogictest v54.1.0 (baseline) Parsed [ 0.023s] (baseline) Checking datafusion-sqllogictest v54.1.0 -> v54.0.0 (minor change) Checked [ 0.077s] 196 checks: 196 pass, 57 skip Summary no semver update required Finished [ 375.512s] datafusion-sqllogictest ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
