peterxcli opened a new pull request, #5044: URL: https://github.com/apache/datafusion-comet/pull/5044
## Which issue does this PR close? Closes #4943. ## Rationale for this change `WideDecimalBinaryExpr` always ran a second null-masking pass in non-ANSI mode, even when no value overflowed. ## What changes are included in this PR? Check for the overflow sentinel before running the null-masking pass. Add regression coverage and Criterion cases for no-overflow, null, overflow, and ANSI shapes. ## How are these changes tested? - `cargo test -p datafusion-comet-spark-expr wide_decimal_binary_expr` - `cargo check -p datafusion-comet-spark-expr --bench wide_decimal` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
