2010YOUY01 commented on issue #11790: URL: https://github.com/apache/datafusion/issues/11790#issuecomment-2284100621
Inspired by @Omega359 's great PR https://github.com/apache/datafusion/pull/11941, I have some suggestion on testing `Utf8View` support for functions: Although most implementation is adapted from existing implementation, but the execution takes another path, so I think comprehensive end-to-end tests are still needed. The good news is there already exists `sqllogictest`s for original string functions, the only thing to do is to duplicate existing testings with `Utf8View` Here are the examples on how to adapt existing test cases for `Utf8View` input 1. For functions takes scalar value, use `arrow_cast()` like https://github.com/apache/datafusion/pull/11941/files#diff-51757b2b1d0a07b88551d88eabeba7f74e11b5217e44203ac7c6f613c0221196 2. For functions read from a table, string column can be converted to `Utf8View` column like https://github.com/apache/datafusion/blob/2cf09566af7d7d5f83a8bdff5f0adda97d40deee/datafusion/sqllogictest/test_files/string_view.slt#L30-L42 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
