martin-g commented on code in PR #2173:
URL:
https://github.com/apache/datafusion-ballista/pull/2173#discussion_r3655487400
##########
ballista/executor/src/config.rs:
##########
@@ -169,17 +169,17 @@ pub struct Config {
help = "Tracing log rotation policy."
)]
pub log_rotation_policy: ballista_core::config::LogRotationPolicy,
- /// Maximum size of incoming gRPC messages in bytes (default: 16MB).
+ /// Maximum size of incoming gRPC messages in bytes (default: 128MB).
Review Comment:
```suggestion
/// Maximum size of incoming gRPC messages in bytes (default: 128MiB).
```
##########
ballista/executor/src/config.rs:
##########
@@ -169,17 +169,17 @@ pub struct Config {
help = "Tracing log rotation policy."
)]
pub log_rotation_policy: ballista_core::config::LogRotationPolicy,
- /// Maximum size of incoming gRPC messages in bytes (default: 16MB).
+ /// Maximum size of incoming gRPC messages in bytes (default: 128MB).
#[arg(
long,
- default_value_t = 16777216,
+ default_value_t = 134217728,
help = "The maximum size of a decoded message at the grpc server side."
)]
pub grpc_server_max_decoding_message_size: u32,
- /// Maximum size of outgoing gRPC messages in bytes (default: 16MB).
+ /// Maximum size of outgoing gRPC messages in bytes (default: 128MB).
Review Comment:
```suggestion
/// Maximum size of outgoing gRPC messages in bytes (default: 128MiB).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
