asolimando commented on code in PR #23651:
URL: https://github.com/apache/datafusion/pull/23651#discussion_r3658220614
##########
datafusion/physical-plan/src/operator_statistics/mod.rs:
##########
@@ -346,52 +411,39 @@ impl StatisticsRegistry {
&self.providers
}
- /// Compute extended statistics for a plan through the provider chain.
+ /// Compute extended statistics for `plan` through the provider chain.
///
- /// Performs a bottom-up tree walk: child statistics are computed
recursively
- /// and passed to providers, mirroring how `partition_statistics` composes
- /// operators. Once
[#20184](https://github.com/apache/datafusion/issues/20184)
- /// lands, the registry can feed enriched base stats directly into
- /// `partition_statistics(child_stats)`, removing the need for a separate
walk.
+ /// Thin wrapper over the single [`StatisticsContext`] walk (the same path
the
+ /// optimizer and EXPLAIN use), so there is one traversal implementation.
+ /// Provider extensions are preserved; see [`StatisticsContext`] for how
they
+ /// propagate up the tree.
///
- /// If no providers are registered, falls back to the plan's built-in
- /// `partition_statistics(None)` with no overhead.
+ /// Children are resolved via [`ExecutionPlan::child_stats_requests`]
(default
Review Comment:
Thanks for pointing that out, I have updated (in
0b6a0213ccd93f7948360036855e04a420831028) the comment to reflect the newly
introduced `StatisticsProvider::child_stats_requests`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
