peterxcli opened a new pull request, #5053: URL: https://github.com/apache/datafusion-comet/pull/5053
## Which issue does this PR close? Closes #4993. ## Rationale for this change ABFS URLs encode the container in URL userinfo, for example `abfss://[email protected]/path`. The process-wide object store cache previously keyed stores by scheme, host, and port only, so different containers in the same storage account shared one cache entry. Since each Azure object store is bound to the container from its URL, a later read could reuse the first container's store and return data from the wrong container. ## What changes are included in this PR? - Preserve URL userinfo when building object store keys for `abfs` and `abfss`, while retaining the existing host-only behavior for other schemes. - Update the cache documentation to describe container-scoped keys. - Add an offline regression test that prepares two containers in the same account with identical configuration and verifies that they resolve to distinct object store instances. ## How are these changes tested? - `cargo test --manifest-path native/Cargo.toml -p datafusion-comet --lib` (`129 passed; 4 ignored`) - `cargo clippy --manifest-path native/Cargo.toml -p datafusion-comet --lib --tests -- -D warnings` - `cargo fmt --manifest-path native/Cargo.toml --all -- --check` The regression constructs the Azure stores locally and does not issue network requests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
