andygrove commented on PR #5053: URL: https://github.com/apache/datafusion-comet/pull/5053#issuecomment-5136837557
Fix looks good and I confirmed it works. Two containers in the same account now resolve to their own stores across tasks, where on `main` the second one gets the first's data. One question before I approve. Within a single plan, `prepare_object_store_with_configs` registers against the shared `session_ctx.runtime_env()` (`planner.rs:1528`), and DataFusion's `get_url_key` strips userinfo, so a second container in the same account would overwrite the first in the registry and both scans would resolve to the same store. Your apache/datafusion#23935 fixes that upstream. Do you know whether a single plan can actually reference two containers in one account today? If it can, could we get a follow-up issue tracking the DF bump? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
