LDM-A commented on PR #23918: URL: https://github.com/apache/datafusion/pull/23918#issuecomment-5094455652
> > There are a bunch of related bugs / issues here: > > > > * [Incorrect results with unique constraints #23634](https://github.com/apache/datafusion/issues/23634) > > * [Incorrect results: GROUP BY column dropped based on a nullable UNIQUE constraint #23819](https://github.com/apache/datafusion/issues/23819) > > * [Incorrect results: GROUP BY returns two rows for the NULL group with a nullable UNIQUE constraint #23820](https://github.com/apache/datafusion/issues/23820) > > > > As well as the issue this PR targets, #23818. Based on [#23636 (review)](https://github.com/apache/datafusion/pull/23636#pullrequestreview-4724560711) , I would guess there might also be an issue with window queries. > > Probably makes sense to look at this whole area holistically. I see that @alamb and @LDM-A have also been working on related tickets, so we should probably make sure we coordinate. > > Thanks for the heads up. I thought with the tests added in #23821 I can implement a fix but did not see the discussion in #23820. I'll follow it and can also close this PR if it will implemented in a combined fashion I have not had too much chance to look into the #23820 ticket after my initial weekend. However @alamb mentioned a refactor of the functional dependency file to take care off all the free functions in it. Maybe since there is multiple PRs coming making changes we can do a refactor then add in the changes. Rather than merging some now then refactoring those with the refactor and finishing some off -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
