theirix commented on code in PR #23653:
URL: https://github.com/apache/datafusion/pull/23653#discussion_r3660719615
##########
datafusion/core/benches/parquet_struct_query.rs:
##########
@@ -60,7 +59,7 @@ fn schema() -> SchemaRef {
}
fn generate_strings(len: usize) -> ArrayRef {
- let mut rng = rng();
+ let mut rng = StdRng::seed_from_u64(0);
Review Comment:
Thank you, @koisew, it makes sense. The `rang::rng()` actually reuses the
global generator, so it wasn't obvious at first glance.
Introduced the mentioned fixes and a few more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
