comphead commented on PR #5040:
URL:
https://github.com/apache/datafusion-comet/pull/5040#issuecomment-5096975678
> > I don't think the upstream `elt` implementation is Spark-compatible? It
doesn't implement ANSI mode, for example.
> > From DF 54.1.0:
> > ```rust
> > // TODO: if spark.sql.ansi.enabled is true,
> > // throw ArrayIndexOutOfBoundsException for invalid indices;
> > // if false, return NULL instead (current behavior).
> > if index < 1 || (index as usize) > num_values {
> > builder.append_null();
> > continue;
> > }
> > ```
>
> One option would be to mix in `CodegenDispatchFallback` and return
`Incompatible` when `expr.failOnError` is true. It would be good to file an
issue upstream for implementing ANSI support too.
Thanks @andygrove for catching this. for ANSI we should start an epic there.
The ANSI flag is already there, and we can try it on `elt`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
