mbutrovich commented on code in PR #5107:
URL: https://github.com/apache/datafusion-comet/pull/5107#discussion_r3674955526
##########
native/core/src/execution/memory_pools/unified_pool.rs:
##########
@@ -121,7 +121,7 @@ impl MemoryPool for CometUnifiedMemoryPool {
}
if let Err(prev) = self
.used
- .fetch_update(Relaxed, Relaxed, |old| old.checked_sub(size))
+ .try_update(Relaxed, Relaxed, |old| old.checked_sub(size))
Review Comment:
I couldn't get clippy to pass locally, so I figured it was a toolchain
upgrade somewhere.
##########
native/core/src/execution/memory_pools/unified_pool.rs:
##########
@@ -121,7 +121,7 @@ impl MemoryPool for CometUnifiedMemoryPool {
}
if let Err(prev) = self
.used
- .fetch_update(Relaxed, Relaxed, |old| old.checked_sub(size))
+ .try_update(Relaxed, Relaxed, |old| old.checked_sub(size))
Review Comment:
I can revert and as long as CI is green we're good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
