mbutrovich commented on code in PR #5107:
URL: https://github.com/apache/datafusion-comet/pull/5107#discussion_r3685105858
##########
spark/src/main/scala/org/apache/comet/CometConf.scala:
##########
@@ -152,7 +152,10 @@ object CometConf extends ShimCometConf {
"statistics, page index, bloom filters) is independent of this flag
and runs " +
"whenever Spark's spark.sql.parquet.filterPushdown is enabled.
Disabling this " +
"flag still lets format-level pruning work; the per-row eval falls
back to " +
- "the CometFilter operator above the scan.")
+ "the CometFilter operator above the scan. This flag's derived
pushdown_filters " +
+ "/ reorder_filters settings can be overridden by explicitly setting
" +
+ "spark.comet.datafusion.execution.parquet.pushdown_filters /
reorder_filters " +
+ "when spark.comet.exec.respectDataFusionConfigs is enabled.")
Review Comment:
Should be addressed in
https://github.com/apache/datafusion-comet/pull/5107/commits/08017243f08f488f62b82402a3763388046956c0,
thanks @andygrove!
##########
spark/src/test/scala/org/apache/comet/exec/CometNativeReaderSuite.scala:
##########
@@ -829,6 +829,78 @@ class CometNativeReaderSuite extends CometTestBase with
AdaptiveSparkPlanHelper
}
}
+ test("row-level pushdown reaches native scan when rowFilterPushdown.enabled
is set") {
Review Comment:
Should be addressed in
https://github.com/apache/datafusion-comet/pull/5107/commits/08017243f08f488f62b82402a3763388046956c0,
thanks @andygrove!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
