neilconway commented on code in PR #22926:
URL: https://github.com/apache/datafusion/pull/22926#discussion_r3675153549
##########
datafusion/core/tests/physical_optimizer/filter_pushdown.rs:
##########
@@ -1753,6 +1817,16 @@ fn col_lit_predicate(
))
}
+fn assert_parent_filter_remains_above_aggregate(plan: Arc<dyn ExecutionPlan>) {
Review Comment:
This passes without the functional changes in this PR; I think you need to
enable `pushdown_filters` instead of using the default config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
