discord9 commented on code in PR #22926:
URL: https://github.com/apache/datafusion/pull/22926#discussion_r3676942167
##########
datafusion/core/tests/physical_optimizer/filter_pushdown.rs:
##########
@@ -1753,6 +1817,16 @@ fn col_lit_predicate(
))
}
+fn assert_parent_filter_remains_above_aggregate(plan: Arc<dyn ExecutionPlan>) {
Review Comment:
Good catch — the default config made these assertions vacuous. I updated the
helper to enable `config.execution.parquet.pushdown_filters` before running the
optimizer. The full focused filter-pushdown module now passes with pushdown
enabled (54 tests).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
