comphead commented on code in PR #5084: URL: https://github.com/apache/datafusion-comet/pull/5084#discussion_r3675521848
########## spark/src/test/resources/sql-tests/expressions/math/arithmetic_ansi.sql: ########## @@ -102,6 +102,33 @@ SELECT a - b FROM ansi_long_overflow WHERE a = -9223372036854775808 query expect_error(ARITHMETIC_OVERFLOW) SELECT a * 2 FROM ansi_long_overflow WHERE a = 9223372036854775807 +-- ============================================================================ +-- Integral divide overflow +-- ============================================================================ + +-- LONG_MIN div -1 should overflow +-- (match on the message body rather than the ARITHMETIC_OVERFLOW condition name, +-- which is not rendered on all Spark versions) +query expect_error(Overflow in integral divide) Review Comment: can we make the error to be consistent with other tests in this file ? ``` query expect_error(ARITHMETIC_OVERFLOW) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
