andygrove opened a new pull request, #5152:
URL: https://github.com/apache/datafusion-comet/pull/5152

   ## Which issue does this PR close?
   
   Backport of #5049 to `branch-1.0`.
   
   ## Rationale for this change
   
   There is currently no convenient way for a Spark user to query which Comet 
version is loaded. The JVM `org.apache.comet.COMET_VERSION` constant exists but 
is only reachable via Scala imports, and the native library logs the version on 
init but that requires driver log access.
   
   ## What changes are included in this PR?
   
   Clean cherry-pick of 3c830f4de (no conflicts):
   
   - The Comet driver plugin sets `spark.comet.version` on the SparkConf during 
`init`, so it is queryable at runtime via 
`spark.conf.get("spark.comet.version")` or `SET spark.comet.version` in SQL. It 
is set before the off-heap check so the version is reported even when Comet is 
otherwise disabled.
   - Documents both the new `spark.comet.version` runtime config and the 
existing `org.apache.comet.COMET_VERSION` (plus `COMET_BRANCH` / 
`COMET_REVISION`) programmatic accessors in the installation guide.
   
   ## How are these changes tested?
   
   Existing test from the original PR: `CometPluginsSuite` (`Comet version is 
exposed as a Spark config`).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to