tomatotomata commented on issue #24022: URL: https://github.com/apache/datafusion/issues/24022#issuecomment-5138130753
I was thinking of taking a first pass on the narrow contract fix in `ScalarValue::new_list`: reconcile the collected non-empty values to the supplied `data_type`, then add regression coverage for nested nullability and the empty/non-empty paths. I would leave the broader PhysicalExpr invariant check separate so the PR stays focused. Does that boundary fit the DataFusion direction, and is there an existing scalar test module you would prefer for the case? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
