kosiew commented on code in PR #23786:
URL: https://github.com/apache/datafusion/pull/23786#discussion_r3689777753
##########
datafusion/physical-plan/src/aggregates/group_values/multi_group_by/mod.rs:
##########
@@ -1620,6 +1641,62 @@ mod tests {
}
}
+ // `(Interval, Int32)` keys: null keys dedup, the Int32 key splits equal
+ // intervals, and emit gives back Interval rather than the raw native.
+ #[test]
+ fn test_group_values_column_interval() {
Review Comment:
Could we extend this runtime test to also intern and emit
`Interval(YearMonth)` and `Interval(DayTime)` arrays? The gate and factory test
now constructs builders for all three interval units, but the end-to-end
append, equality, and emit coverage currently only exercises `MonthDayNano`. A
small table-driven unit test would help confirm that all three interval units
behave as expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
