alamb commented on code in PR #23609:
URL: https://github.com/apache/datafusion/pull/23609#discussion_r3693634978
##########
datafusion/physical-plan/src/aggregates/topk/hash_table.rs:
##########
@@ -73,6 +73,50 @@ pub trait ArrowHashTable {
fn find_or_insert(&mut self, row_idx: usize, replace_idx: usize) ->
(usize, bool);
}
+enum StringArrayType {
Review Comment:
If you made this a trait you could avoid having to check `self` each
dispatch (aka you would figure out the type once, and then always call the
right function)
That would probably take some more finagling to avoid a new StringHashTable
for each string type (when all that is different is the access function 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
