MassivePizza commented on code in PR #23609:
URL: https://github.com/apache/datafusion/pull/23609#discussion_r3703530302
##########
datafusion/physical-plan/src/aggregates/topk/hash_table.rs:
##########
@@ -73,6 +73,50 @@ pub trait ArrowHashTable {
fn find_or_insert(&mut self, row_idx: usize, replace_idx: usize) ->
(usize, bool);
}
+enum StringArrayType {
Review Comment:
I think making StringHashTable generic is the only alternative to enum
(which is itself super cheap, just one little branch and jump). This would have
been nice and simple if `arrow_array::StringArrayType` didn't have a lifetime
bound... but I'm trying anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
