neilconway commented on PR #23566: URL: https://github.com/apache/datafusion/pull/23566#issuecomment-5147991332
@simonvandel Sorry for the delay in responding here! > It's true that eliminate_join.rs has no unit tests added in this PR, so in that sense there is a gap. But I have added SLT tests for the optimization which show positive/negative cases. Do you still want unit tests as well, even if that means we now test the code redundantly? It's probably fine to skip, although the existing `EliminateJoin` codepaths have both unit and SLT tests, so there is precedent. I don't feel super strongly about it though. If you can you fix the merge conflict and make a call on if you'd like to add unit tests, and I think we're good to land this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
