sandugood commented on code in PR #2215:
URL:
https://github.com/apache/datafusion-ballista/pull/2215#discussion_r3695347176
##########
ballista/scheduler/src/state/execution_graph.rs:
##########
@@ -1364,10 +1361,9 @@ impl ExecutionGraph for StaticExecutionGraph {
executor_id,
})
.collect();
- self.stages.insert(
- stage_id,
-
ExecutionStage::UnResolved(stage.to_unresolved(failure_reasons)?),
- );
+ let unresolved_stage = stage.to_unresolved(failure_reasons)?;
Review Comment:
When this errors, the `running_tasks` was already collected, but it is now
discarded. Better than a vanished stage, but it's a distinct bad state. Maybe
add a line to "Are there any user facing changes"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
