QuakeWang commented on code in PR #2215:
URL:
https://github.com/apache/datafusion-ballista/pull/2215#discussion_r3697587096
##########
ballista/scheduler/src/state/execution_graph.rs:
##########
@@ -1364,10 +1361,9 @@ impl ExecutionGraph for StaticExecutionGraph {
executor_id,
})
.collect();
- self.stages.insert(
- stage_id,
-
ExecutionStage::UnResolved(stage.to_unresolved(failure_reasons)?),
- );
+ let unresolved_stage = stage.to_unresolved(failure_reasons)?;
Review Comment:
Good point. The running-task list was also discarded on this error path
before this PR, but preserving the stage makes the resulting behavior worth
stating explicitly: the stage remains `Running`, its task tracking is retained,
and the error propagates before a `CancelTasks` event can be emitted. I have
clarified this in the user-facing changes section. Changing cancellation or
recovery policy would be outside the failure-atomic transition scope of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
