comphead commented on code in PR #5050:
URL: https://github.com/apache/datafusion-comet/pull/5050#discussion_r3696042534
##########
spark/src/main/scala/org/apache/comet/serde/arithmetic.scala:
##########
@@ -91,6 +90,25 @@ trait MathBase {
Unsupported(Some(s"Unsupported datatype $dt"))
}
+ // Native decimal Add/Subtract/Divide/IntegralDivide/Remainder scale-aligns
operands by
+ // multiplying by 10^|delta|, which overflows (subtract-with-overflow panic
in debug, silent
+ // wrap in release) whenever any operand or the result has negative scale.
See issue #5013.
+ private[comet] val negScaleDecimalArithmeticReason: String =
+ "Arithmetic on negative-scale decimal is not supported natively"
+
+ private[comet] def negScaleDecimalRejection(expr: BinaryArithmetic):
Option[Unsupported] = {
Review Comment:
do we really need changes in this file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
