0lai0 commented on PR #5050: URL: https://github.com/apache/datafusion-comet/pull/5050#issuecomment-5152669870
Thanks @comphead. Good point on nested types, my guards match `case d: DecimalType if d.scale < 0`, so they don't match `ArrayType(DecimalType(10, -1))` or a struct field with negative scale. On plan-level scanning or per-expression guards, I don't have a strong view either way. @andygrove, do you have a preference? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
