peterxcli commented on PR #5167: URL: https://github.com/apache/datafusion-comet/pull/5167#issuecomment-5159701308
@andygrove thanks for the review! > `invalid_date_message` should validate the year before the month and day. Added Java `LocalDate` year-range validation before month/day validation, including Spark’s exact error message. Added a combined invalid-input case to verify year-first precedence. > Compare the exception message parameters and add an out-of-range year test. The test now compares exception class, error class, SQL state, `getMessageParameters`, and the full message. Added cases for `make_date(1000000000, 1, 1)` and an invalid year/month/day combination. > Document the narrower chrono year range and create a tracking issue. Filed https://github.com/apache/datafusion-comet/issues/5208 and restored `CometMakeDate.getCompatibleNotes()` documenting chrono’s `[-262143, 262142]` limitation. > Consider moving `causeChain` and `deepestSparkThrowable` into `CometTestBase`. Found five equivalent cause-chain traversals across four suites. Filed https://github.com/apache/datafusion-comet/issues/5223) to centralize `causeChain` in `CometTestBase`. `deepestSparkThrowable` remains local because its selection policy is unique, but it can reuse the shared helper. > Avoid hardcoding the Spark-version-specific `DATETIME_FIELD_OUT_OF_BOUNDS` subclass. Reworded the SQL test comment to state that the subclass and message parameters vary by Spark version, without pinning a specific version boundary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
