peterxcli commented on PR #5174: URL: https://github.com/apache/datafusion-comet/pull/5174#issuecomment-5160779575
@andygrove thanks for the review! review change is pushed. please take another look, thanks! > Could you add a microbenchmark and post before and after numbers? Include high out-of-bounds rates and `utf8` alongside `int`. Added an 8-case Criterion benchmark: Int32/UTF-8 × null/non-null default × 0%/50% OOB. Posted before/after numbers in the PR description. > For a null default the `zip` cannot change anything. Would you consider skipping it? When no default expression is supplied, `list_extract` now uses a single Arrow `take`; the mask and `zip` are removed. > Would you be up for either keeping the `MutableArrayData` path when the default is non-null, or finding something cheaper than `zip`? All explicit defaults, including `split_part`’s non-null default and explicit null defaults—retain the original single-pass `MutableArrayData` path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
