alamb commented on code in PR #24053: URL: https://github.com/apache/datafusion/pull/24053#discussion_r3706805795
########## .github/pull_request_template.md: ########## @@ -11,12 +11,19 @@ We generally require a GitHub issue to be filed for all bug fixes and enhancemen <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. + +Please explain the problem you are trying to solve in terms of the user-visible +behavior, rather than the implementation. + +For example, "The code in `foo.rs` doesn't handle nulls" is a symptom of the +implementation. "COUNT(DISTINCT) returns wrong results when the column contains +nulls" is the user-visible problem. Review Comment: I think this is a bit too verbose for every PR -- how about we add this backstory / content to https://datafusion.apache.org/contributor-guide/index.html#creating-pull-requests and then add a link to that section here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
