alamb commented on code in PR #11970:
URL: https://github.com/apache/datafusion/pull/11970#discussion_r1715747722
##########
datafusion/sqllogictest/test_files/string_view.slt:
##########
@@ -913,7 +913,7 @@ EXPLAIN SELECT
FROM test;
----
logical_plan
-01)Projection: find_in_set(CAST(test.column1_utf8view AS Utf8),
Utf8("a,b,c,d")) AS c
Review Comment:
I think we should probably add a test that actually invokes `find_in_set`
with a `StringVieAwArray` argument.
However, I think @2010YOUY01 has some ideas on a more general testing
framework, so maybe this is good enough for now. Let me know what you think
https://github.com/apache/datafusion/issues/11790#issuecomment-2284100621
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
