alamb commented on issue #21246: URL: https://github.com/apache/datafusion/issues/21246#issuecomment-5171925455
> so i'd love to hear what you would prefer, that I make ProjectionExec::try_new reject duplicate output names with a test, or should filter pushdown preserve the column index for directly constructed physical plans? I woudl recommend starting with enforcing the "no duplicated column names" invariant in `ProjectionExec::try_new` and see how far that gets us. I think we can justify starting to error by the fact that the plan an produce wrong results In general I think DataFusion requires unique names in its schemas so we can refer to this as well: - https://datafusion.apache.org/contributor-guide/specification/invariants.html - https://github.com/apache/datafusion/blob/main/datafusion/common/src/dfschema.rs#L240 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
