alamb commented on code in PR #11962:
URL: https://github.com/apache/datafusion/pull/11962#discussion_r1715778889
##########
datafusion/functions/src/string/repeat.rs:
##########
@@ -87,18 +95,35 @@ fn repeat<T: OffsetSizeTrait>(args: &[ArrayRef]) ->
Result<ArrayRef> {
let result = string_array
.iter()
.zip(number_array.iter())
- .map(|(string, number)| match (string, number) {
- (Some(string), Some(number)) if number >= 0 => {
- Some(string.repeat(number as usize))
- }
- (Some(_), Some(_)) => Some("".to_string()),
- _ => None,
- })
+ .map(|(string, number)| repeat_common(string, number))
.collect::<GenericStringArray<T>>();
Ok(Arc::new(result) as ArrayRef)
}
+fn repeat_utf8view(args: &[ArrayRef]) -> Result<ArrayRef> {
+ let string_view_array = as_string_view_array(&args[0])?;
+ let number_array = as_int64_array(&args[1])?;
+
+ let result = string_view_array
+ .iter()
+ .zip(number_array.iter())
+ .map(|(string, number)| repeat_common(string, number))
+ .collect::<StringArray>();
+
+ Ok(Arc::new(result) as ArrayRef)
+}
+
+fn repeat_common(string: Option<&str>, number: Option<i64>) -> Option<String> {
Review Comment:
I think you could make this perform much better by avoiding the `String` and
instead building the output directly with `StringViewBuilder`
https://docs.rs/arrow/latest/arrow/array/type.StringViewBuilder.html
here is an example of how to use them:
https://github.com/apache/arrow-rs/pull/6240
I realize this just follows the same model as was here. However, if we are
messing with the code it might be nice to make it faster while we are at it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
