tlm365 commented on code in PR #11962:
URL: https://github.com/apache/datafusion/pull/11962#discussion_r1716788840
##########
datafusion/functions/src/string/repeat.rs:
##########
@@ -87,18 +95,35 @@ fn repeat<T: OffsetSizeTrait>(args: &[ArrayRef]) ->
Result<ArrayRef> {
let result = string_array
.iter()
.zip(number_array.iter())
- .map(|(string, number)| match (string, number) {
- (Some(string), Some(number)) if number >= 0 => {
- Some(string.repeat(number as usize))
- }
- (Some(_), Some(_)) => Some("".to_string()),
- _ => None,
- })
+ .map(|(string, number)| repeat_common(string, number))
.collect::<GenericStringArray<T>>();
Ok(Arc::new(result) as ArrayRef)
}
+fn repeat_utf8view(args: &[ArrayRef]) -> Result<ArrayRef> {
+ let string_view_array = as_string_view_array(&args[0])?;
+ let number_array = as_int64_array(&args[1])?;
+
+ let result = string_view_array
+ .iter()
+ .zip(number_array.iter())
+ .map(|(string, number)| repeat_common(string, number))
+ .collect::<StringArray>();
+
+ Ok(Arc::new(result) as ArrayRef)
+}
+
+fn repeat_common(string: Option<&str>, number: Option<i64>) -> Option<String> {
Review Comment:
@alamb thanks so much for reviewing. I will take a look!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
