NoahKusaba commented on PR #2217: URL: https://github.com/apache/datafusion-ballista/pull/2217#issuecomment-5174586403
> instead of using docker compose for tests, would it make sense to use testcontainers? we already use it, you could find example at > > https://github.com/apache/datafusion-ballista/blob/187a650630b418f4aa15ff9635f19b77728b7628/examples/tests/object_store.rs#L42 > instead of using docker compose for tests, would it make sense to use testcontainers? we already use it, you could find example at > > https://github.com/apache/datafusion-ballista/blob/187a650630b418f4aa15ff9635f19b77728b7628/examples/tests/object_store.rs#L42 Good callout, I made the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
