2010YOUY01 commented on code in PR #24061:
URL: https://github.com/apache/datafusion/pull/24061#discussion_r3702958428
##########
datafusion/physical-plan/src/aggregates/mod.rs:
##########
@@ -3427,8 +3418,8 @@ mod tests {
assert!(final_stats.total_byte_size.get_value().is_some());
let task_ctx = if spill {
- // enlarge memory limit to let the final aggregation finish
- new_spill_ctx(2, 2600)
+ // Enlarge the memory limit enough to replay spilled states.
+ new_spill_ctx(2, 4640)
Review Comment:
The legacy implementation underestimate the memory usage somehow, so here it
relaxes the memory budget
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
