2010YOUY01 commented on code in PR #24061:
URL: https://github.com/apache/datafusion/pull/24061#discussion_r3725827655
##########
datafusion/physical-plan/src/aggregates/ordered_final_stream.rs:
##########
@@ -230,14 +230,18 @@ impl OrderedFinalSpillContext {
} = self;
let spill_schema = Arc::clone(spill_manager.schema());
+ // The merge and replay table are two components of the same aggregate
+ // operator. Keep them under one consumer registration so a fair memory
+ // pool does not divide this operator's quota between its own phases.
Review Comment:
Yes, it mirrors the existing behavior. It's only get caught by the existing
test after this PR, likely because partial/final 2-staged aggregation has
better test coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
