Smallfu666 commented on PR #5162:
URL:
https://github.com/apache/datafusion-comet/pull/5162#issuecomment-5174995223
Thanks! All three are handled in the latest revision:
1. Dropped the dead interval block — those DataFrames were built but never
actually used by the query, so it wasn't covering anything.
2. Reworked `checkOverflow` to assert the Spark and Comet substrings
separately:
- Spark 3.4/3.5: Spark `"caused overflow"` vs Comet `"byte overflow"` /
`"short overflow"`
- Spark 4.x: both sides `"byte overflow"` / `"short overflow"`
So the old empty-string assertion is gone.
3. I didn't open a separate `abs` issue — it's already tracked as item 5 of
#5071, and this PR covers the `UnaryMinus` half (item 4 there).
Rebased onto the latest `main` and reran the native and Spark 3.5 / 4.0
suites — all green.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
