sam-1112 commented on PR #5215: URL: https://github.com/apache/datafusion-comet/pull/5215#issuecomment-5176887403
Thanks for digging into those edge cases, it's really helpful. I have pushed the last bits: (1) removed the stray `///`; (2) added a dictionary case with nulls in the values (all-valid keys). Also opened #5246 for the RLike Criterion bench. I also agree on the Utf8View reachability point; I'll skip the e2e case in `rlike_rust.sql` for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
