sam-1112 opened a new pull request, #5215: URL: https://github.com/apache/datafusion-comet/pull/5215
## Which issue does this PR close? Closes \#5102. ## Rationale for this change `RLike` array evaluation hard-downcasts to `StringArray` and panics on other Arrow string layouts (`LargeUtf8` / `Utf8View`). This PR keeps the existing row loop with the plan-time compiled `Regex` and only fixes downcast robustness. ## What changes are included in this PR? - Generalize matching over Arrow string layouts via `StringArrayType`, dispatching on `Utf8` / `LargeUtf8` / `Utf8View`. - Replace `expect` panics with typed downcasts and `exec_err` for unsupported input types. - Apply the same string-layout handling to the dictionary fast path (match dictionary values, then `take`); scalar input remains a thin wrapper around the precompiled `Regex`. ## How are these changes tested? - `cargo test -p datafusion-comet-spark-expr --lib` (570 passed) - `cargo clippy -p datafusion-comet-spark-expr --lib --tests -- -D warnings` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
