kosiew commented on code in PR #24039:
URL: https://github.com/apache/datafusion/pull/24039#discussion_r3711921705
##########
datafusion/physical-plan/src/aggregates/mod.rs:
##########
@@ -1596,7 +1671,13 @@ impl AggregateExec {
}
num_rows
} else if value == 0 {
- child_statistics.num_rows
+ // `limit_options` becomes a soft limit on the groups built
Review Comment:
Could we add a regression test for this new `limit_options` exception? In
particular, it would be helpful to cover empty input with one or more empty
grouping sets and a small limit, and verify that the empty grouping-set rows
are still returned. The comment explains that initialization bypasses the soft
limit, but a test would make sure this behavior stays intact.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
