peterxcli commented on code in PR #5225:
URL: https://github.com/apache/datafusion-comet/pull/5225#discussion_r3712097747
##########
spark/src/main/scala/org/apache/spark/sql/comet/DecimalPrecision.scala:
##########
@@ -45,6 +45,15 @@ object DecimalPrecision {
// happen if the Spark version is < 3.4
case e: BinaryArithmetic if e.left.prettyName == "promote_precision" => e
+ // Recursive exprToProto calls can re-promote every decimal binary
operator below. Collapse
+ // only equivalent wrappers so the shared promotion rule remains
idempotent.
+ case outer @ CheckOverflow(
Review Comment:
filed. https://github.com/apache/datafusion-comet/issues/5248
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
